Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce aria-selected attribute to dialog tabs #3547

Closed
f1ames opened this issue Oct 7, 2019 · 0 comments · Fixed by #3806
Closed

Introduce aria-selected attribute to dialog tabs #3547

f1ames opened this issue Oct 7, 2019 · 0 comments · Fixed by #3806
Assignees
@Dumluregn
Labels
plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.
Milestone
Iteration 2020-1 ...

Comments

@f1ames
Copy link
Contributor

f1ames commented Oct 7, 2019

Type of report

Feature request

Provide description of the new feature

  1. Go to https://ckeditor.com/docs/ckeditor4/latest/examples/fullpreset.html.
  2. Open any dialog with tabs.

Tabs don't have aria-selected attributes.

What is the expected behavior of the proposed feature?

While the current behaviour is in line with ARIA specification and works fine in officially supported environment it might be problematic for some other browsers / screen readers combinations. We should consider introducing aria-selected attribute to make dialogs more intact with various environments.
@f1ames f1ames added type:feature A feature request. plugin:dialog The plugin which probably causes the issue. target:major Any docs related issue that should be merged into a major branch. support:2 An issue reported by a commercially licensed client. labels Oct 7, 2019
@Comandeer Comandeer added the status:confirmed An issue confirmed by the development team. label Oct 7, 2019
@f1ames f1ames added this to the 4.14.0 milestone Oct 10, 2019
@f1ames f1ames removed the target:major Any docs related issue that should be merged into a major branch. label Nov 12, 2019
@f1ames f1ames modified the milestones: 4.14.0, Planning Dec 11, 2019
@f1ames f1ames modified the milestones: Planning, Next Jan 17, 2020
@Dumluregn Dumluregn mentioned this issue Jan 21, 2020
Merged
2 tasks
@msamsel msamsel mentioned this issue Jan 23, 2020
Closed
@Dumluregn Dumluregn self-assigned this Jan 23, 2020
This was referenced Aug 20, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dumluregn Dumluregn

Labels
plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.
Projects
None yet
Milestone
Iteration 2020-1 (4.14.0)
Development

Successfully merging a pull request may close this issue.

Add aria-selected attribute for active dialog tab ckeditor/ckeditor4
3 participants
@f1ames @Comandeer @Dumluregn