Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focusing dialog tab doesn't reset focus order in dialog #3474

Closed
f1ames opened this issue Sep 20, 2019 · 1 comment
Closed

Focusing dialog tab doesn't reset focus order in dialog #3474

f1ames opened this issue Sep 20, 2019 · 1 comment
Assignees
@msamsel
Labels
accessibility Issue related to accessibility. plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Milestone
4.13.1

Comments

@f1ames
Copy link
Contributor

f1ames commented Sep 20, 2019

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Go to https://ckeditor.com/docs/ckeditor4/latest/examples/fullpreset.html.
  2. Open Find/Replace dialog.
  3. Click Find tab.
  4. Press Tab.
  5. Repeat 3 and 4 step.

Expected result

After focusing dialog tab, pressing Tab focuses first focusable item in dialog tab.

Actual result

After focusing dialog tab, pressing Tab focuses item after the one last focused.

Other details

dialog focus

  • Browser: All
  • OS: All
  • CKEditor version: 4.10.0/4.12.1
  • Installed CKEditor plugins: dialog
@f1ames f1ames added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:dialog The plugin which probably causes the issue. target:minor Any docs related issue that can be merged into a master or major branch. accessibility Issue related to accessibility. labels Sep 20, 2019
@f1ames f1ames added this to the Next milestone Sep 20, 2019
@f1ames f1ames added the support:2 An issue reported by a commercially licensed client. label Sep 20, 2019
@msamsel msamsel assigned msamsel and unassigned msamsel Sep 23, 2019
This was referenced Sep 25, 2019
Open
Merged
@f1ames f1ames removed the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 12, 2019
@f1ames
Copy link
Contributor Author

f1ames commented Dec 4, 2019

Fixed with 1ff8ee2.

@f1ames f1ames closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
accessibility Issue related to accessibility. plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Milestone
4.13.1
Development

No branches or pull requests
2 participants
@f1ames @msamsel