Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple widgets drag&drop with specific selection doesn't work well #3441

Closed
Dumluregn opened this issue Sep 18, 2019 · 3 comments · Fixed by #3476
Closed

Multiple widgets drag&drop with specific selection doesn't work well #3441

Dumluregn opened this issue Sep 18, 2019 · 3 comments · Fixed by #3476
Assignees
Labels
plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@Dumluregn
Copy link
Contributor

Dumluregn commented Sep 18, 2019

Type of report

Feature request

Provide detailed reproduction steps (if any)

  1. Open /tests/plugins/widget/manual/clipboardhtml test.
  2. Make selection containing a few widgets, but starting and ending with text.
  3. Drag&drop.

Expected result

Widgets content should change as described in test scenario.

Actual result

Widgets content doesn't change.

Other details

  • Browser: Firefox
  • OS: macOS
  • CKEditor version: 4.13
  • Installed CKEditor plugins: widget
@Dumluregn Dumluregn added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:clipboard The plugin which probably causes the issue. plugin:widget The plugin which probably causes the issue. labels Sep 18, 2019
@Comandeer Comandeer self-assigned this Sep 18, 2019
@Comandeer Comandeer added type:feature A feature request. and removed plugin:clipboard The plugin which probably causes the issue. type:bug A bug. labels Sep 18, 2019
@Comandeer
Copy link
Member

It's more of a feature request, because current implementation is built around modifying copied content, not altering pasted one. Because of that, handling d&d will require altering the whole d&d logic to introduce new serializing behaviour to it.

@f1ames
Copy link
Contributor

f1ames commented Sep 19, 2019

@Dumluregn @Comandeer how did it worked before the recent changes in clipboard? From what I understand it works as before the change:

Widgets content doesn't change.

So we are missing the part for handling d'n'd (with selection containing widgets)? If so we can handle it as a follow-up.

@f1ames f1ames added this to the Next milestone Sep 19, 2019
@Comandeer
Copy link
Member

It is supported only on d&d of one widget – as it was the only case supported by the previous implementation. I didn't extend drag handler, only copy one.

@f1ames f1ames modified the milestones: 4.13.1, 4.14.0 Sep 26, 2019
@f1ames f1ames added the target:major Any docs related issue that should be merged into a major branch. label Sep 26, 2019
@f1ames f1ames removed the target:major Any docs related issue that should be merged into a major branch. label Nov 12, 2019
@f1ames f1ames modified the milestones: 4.14.0, Iteration 2019-1 Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants