Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WSC to 5.0.1.3 #2716

Closed
mlewand opened this issue Jan 3, 2019 · 3 comments
Closed

Update WSC to 5.0.1.3 #2716

mlewand opened this issue Jan 3, 2019 · 3 comments
Assignees
@mlewand
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.11.2

Comments

@mlewand
Copy link
Contributor

mlewand commented Jan 3, 2019 •
edited
Loading

Type of report

Task

Provide detailed reproduction steps (if any)

WSC team notified us that 5.0.1.3 version fixes IE10 bug when closing the dialog.

It actually turned out that it is supposed to fix WebSpellChecker/ckeditor-plugin-wsc#52 instead of previously mentioned bug.

Since this particular version doesn't change anything except that fix we could include it in minor release.
@mlewand mlewand changed the title Update WSC Update WSC to 5.0.1.3 Jan 3, 2019
@mlewand mlewand added type:task Any other issue (refactoring, typo fix, etc). good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. labels Jan 3, 2019
@mlewand mlewand added this to the 4.11.2 milestone Jan 3, 2019
@mlewand mlewand self-assigned this Jan 3, 2019
@mlewand
Copy link
Contributor Author

mlewand commented Jan 3, 2019

Actually I created preset with the WSC updated, and the IE10 issue is still there. Asking @Comandeer to confirm my observation.

@mlewand
Copy link
Contributor Author

mlewand commented Jan 3, 2019

After clarifying this with WSC team it turned out that the bug that was supposed to be fixed by 5.0.1.3 release is WebSpellChecker/ckeditor-plugin-wsc#52. We need to verify whether it was fixed.

This was referenced Jan 3, 2019
Merged
Merged
@mlewand
Copy link
Contributor Author

mlewand commented Jan 4, 2019

Fixed with #2720.

@mlewand mlewand closed this as completed Jan 4, 2019
@Dumluregn Dumluregn added the status:confirmed An issue confirmed by the development team. label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.11.2
Development

No branches or pull requests
2 participants
@mlewand @Dumluregn