Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugin definition with isEnvironmentSupported optional member #2692

Closed
jacekbogdanski opened this issue Dec 19, 2018 · 0 comments · Fixed by #2693
Closed

Update plugin definition with isEnvironmentSupported optional member #2692

jacekbogdanski opened this issue Dec 19, 2018 · 0 comments · Fixed by #2693
Assignees
@jacekbogdanski
Labels
changelog:api A changelog entry should be put in the API section of the changelog. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.12.0

Comments

@jacekbogdanski
Copy link
Member

Type of report

Task

Provide description of the task

Some of our plugins work only on chosen environments. As an example, easyimage is working only on modern browsers. It would be nice to have a dedicated place where such information is placed. The best option seems to treat isEnvironmentSupported as an abstract, optional member of the plugin definition. In the future, we may use this function to conditionally load plugins directly from the loader, but for now, it should be enough to just document it in the plugin definition.
@jacekbogdanski jacekbogdanski added type:task Any other issue (refactoring, typo fix, etc). status:confirmed An issue confirmed by the development team. labels Dec 19, 2018
@jacekbogdanski jacekbogdanski self-assigned this Dec 19, 2018
This was referenced Dec 19, 2018
Merged
Closed
@f1ames f1ames added this to the 4.12.0 milestone Jun 13, 2019
@jacekbogdanski jacekbogdanski mentioned this issue Jun 13, 2019
Open
@f1ames f1ames added the changelog:api A changelog entry should be put in the API section of the changelog. label Jun 17, 2019
@f1ames f1ames mentioned this issue Jun 26, 2019
Closed
@sculpt0r sculpt0r mentioned this issue Dec 14, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
changelog:api A changelog entry should be put in the API section of the changelog. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Add isSupportedEnvironment virtual member ckeditor/ckeditor4
2 participants
@f1ames @jacekbogdanski