Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins configurations options should accept also arrays #1802

Closed
Comandeer opened this issue Mar 15, 2018 · 0 comments
Closed

Plugins configurations options should accept also arrays #1802

Comandeer opened this issue Mar 15, 2018 · 0 comments
Assignees
@Comandeer
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.10.0

Comments

@Comandeer
Copy link
Member

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

  1. Try to pass array into one of plugins options (plugins, extraPlugins and removePlugins), e.g.:
config.plugins = [ 'toolbar', 'clipboard' ];

Expected result

Plugins are added/removed correctly.

Actual result

Editor raises an error.

Other details

This issue would require to alter parsing of these options in core/editor.js:
https://github.com/ckeditor/ckeditor-dev/blob/9204212e0217ba86fe2ec871d1649693d5808154/core/editor.js#L494-L516
@Comandeer Comandeer added type:feature A feature request. status:confirmed An issue confirmed by the development team. changelog:api A changelog entry should be put in the API section of the changelog. labels Mar 15, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:major Any docs related issue that should be merged into a major branch. labels Apr 19, 2018
@Comandeer Comandeer self-assigned this Apr 26, 2018
@Comandeer Comandeer mentioned this issue Apr 26, 2018
Merged
2 tasks
@mlewand mlewand added this to the 4.10.0 milestone Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.10.0
Development

No branches or pull requests
2 participants
@Comandeer @mlewand