Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justify Buttons Disabled for styled element in Enter_BR mode #1479

Closed
renvieir opened this issue Jan 19, 2018 · 4 comments
Closed

Justify Buttons Disabled for styled element in Enter_BR mode #1479

renvieir opened this issue Jan 19, 2018 · 4 comments
Assignees
Labels
plugin:justify The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:1 An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@renvieir
Copy link

renvieir commented Jan 19, 2018

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

This was originally reported in issue 1436. But it was closed after cannot reproduce the bug. Reporting it again since now I can provide more details and evidences.

Provide detailed reproduction steps (if any)

  1. Copy one paragraph of https://br.lipsum.com/feed/html
  2. Enter https://codepen.io/renvieir/pen/MrVEmj
  3. Paste the text in editor
  4. Click over the text
  5. See that alignment buttons are disabled

Alternative way to reproduce the BUG (Please notice that Enter_BR mode is active):

  1. Open link: https://codepen.io/msamsel/pen/LeabeB
  2. Write something
  3. Select written text and apply custom font (e.g. Arial)
  4. Try to justify text

Expected result

Alignment Buttons should be enabled

Actual result

Alignment Buttons are disabled

ckeditor_entermode

Other details

  • Browsers:
    • IE version 11.98.16299.0
    • Edge version 41.16299.15.0
    • Firefox version 57.0.4
  • OS: Windows 10 Pro Version 10.0.16299 Build 16299
  • CKEditor version: 4.8.0
  • CKEditor plugins: Justify
@msamsel msamsel self-assigned this Jan 22, 2018
@msamsel
Copy link
Contributor

msamsel commented Jan 22, 2018

Hi,

based on this description currently I can say something more. If you take a closer look into elementspath in editor's footer, you can notice that <span> appears in editor's content.
Justification might be only applied to block type elements, so here when we are inside a <span> justification is disabled. Problem specific to your case is that pasted data are wrapped with span. You can check what exactly is pasted in this sample: https://codepen.io/mlewand/pen/xqwRJb

I'll modify your description to get easier way to reproduce the case. What you can do in current case is to not use "Enter BR" mode or paste content as plain text with Ctrl+Shift+V.

@msamsel msamsel changed the title Justify Buttons Disabled Justify Buttons Disabled for styled element in Enter_BR mode Jan 22, 2018
@msamsel msamsel removed their assignment Jan 22, 2018
@msamsel msamsel added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:justify The plugin which probably causes the issue. labels Jan 22, 2018
@keeehlan
Copy link

Are there any updates on the status of this bug? @msamsel

@keeehlan
Copy link

Are there any updates on the status of this bug? @msamsel

Bump.

@lslowikowska lslowikowska added the support:3 An issue reported by a commercially licensed client. label Jan 3, 2019
@msamsel msamsel self-assigned this Jan 9, 2019
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Feb 18, 2019
@mlewand mlewand added this to the 4.11.4 milestone Feb 19, 2019
@f1ames
Copy link
Contributor

f1ames commented Mar 19, 2019

Closed in ddc76e0.

@f1ames f1ames closed this as completed Mar 19, 2019
@lslowikowska lslowikowska added support:1 An issue reported by a commercially licensed client. and removed support:3 An issue reported by a commercially licensed client. labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:justify The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:1 An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

6 participants