Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make magic line line element identifiable using attribute #1441

Closed
jswiderski opened this issue Jan 12, 2018 · 2 comments
Closed

Make magic line line element identifiable using attribute #1441

jswiderski opened this issue Jan 12, 2018 · 2 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:magicline The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.9.0

Comments

@jswiderski
Copy link
Contributor

jswiderski commented Jan 12, 2018 •
edited by mlewand
Loading

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

The magic line as well as drop line, showing up when block widget is being dragged, could use a CSS class or data attribute that could help identifying them as well as adding additional styling.

In fact Line Utils plugin elements are marked with data-cke-lineutils-line attribute, so it would make sense to mark it with data-cke-magic-line for consistency.
@jswiderski jswiderski added type:feature A feature request. support An issue reported by a commercially licensed client. labels Jan 12, 2018
@mlewand
Copy link
Contributor

mlewand commented Jan 12, 2018

Interestingly magicline has nothing to identify it, so in fact it would be nice to have it explicitly marked. It could be either class or data attribute. Id is not a good idea, due to mentioned fact that it could be within the same document which would violate HTML (thus I'll remove this proposal from original description).

@mlewand mlewand added status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Jan 12, 2018
@mlewand mlewand added this to the Backlog milestone Jan 12, 2018
@jswiderski
Copy link
Contributor Author

As discussed with @mlewand the drop line is controlled by lineutils plugin and the line has the data-cke-lineutils-line which can give same level of flexibility as CSS class thus it doesn't make sense to add anything new to it but only focusing on magic-line.

@mlewand mlewand added plugin:magicline The plugin which probably causes the issue. target:major Any docs related issue that should be merged into a major branch. labels Jan 12, 2018
@mlewand mlewand changed the title Make magic line and drop line identifiable by CSS class Make magic line line element identifiable by attribute Jan 13, 2018
@mlewand mlewand changed the title Make magic line line element identifiable by attribute Make magic line line element identifiable using attribute Jan 13, 2018
@jacekbogdanski jacekbogdanski mentioned this issue Jan 15, 2018
Merged
2 tasks
@f1ames f1ames modified the milestones: Backlog, 4.9.0 Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:magicline The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
3 participants
@f1ames @jswiderski @mlewand