Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keystroke labels should work for function keys (like F7, F8) #1338

Closed
f1ames opened this issue Dec 11, 2017 · 1 comment
Closed

Keystroke labels should work for function keys (like F7, F8) #1338

f1ames opened this issue Dec 11, 2017 · 1 comment
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.9.0

Comments

@f1ames
Copy link
Contributor

f1ames commented Dec 11, 2017

Are you reporting a feature request or a bug?

Feature request

Check if the issue is already reported

Extracted from #1154.

Provide detailed reproduction steps (if any)

Using keystrokes like editor.setKeystroke( CKEDITOR.CTRL + 117, 'Play' );, will display Play (Ctrl+u) instead of Play (Ctrl+f7).

The cause of this issue is described here: #1154 (comment).

Other details

  • Browser: All
  • OS: All
  • CKEditor version: 4.6.0
  • Installed CKEditor plugins: -
@f1ames f1ames added changelog:api A changelog entry should be put in the API section of the changelog. status:confirmed An issue confirmed by the development team. type:feature A feature request. labels Dec 11, 2017
@f1ames f1ames mentioned this issue Dec 11, 2017
Closed
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. labels Dec 29, 2017
@mlewand mlewand added target:major Any docs related issue that should be merged into a major branch. and removed target:minor Any docs related issue that can be merged into a master or major branch. labels Jan 9, 2018
@engineering-this engineering-this mentioned this issue Jan 10, 2018
Merged
2 tasks
@mlewand mlewand changed the title Keystroke mapping should work for function keys (like F7,F8) Keystroke labels should work for function keys (like F7, F8) Jan 15, 2018
@mlewand mlewand added this to the 4.9.0 milestone Jan 15, 2018
@mlewand
Copy link
Contributor

mlewand commented Jan 15, 2018

Fixed with #1427.

@mlewand mlewand closed this as completed Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
2 participants
@f1ames @mlewand