Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is necessary to wrap some paths in CKEDITOR.getUrl() #1194

Open
trypton opened this issue Nov 21, 2017 · 1 comment
Open

It is necessary to wrap some paths in CKEDITOR.getUrl() #1194

trypton opened this issue Nov 21, 2017 · 1 comment
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@trypton
Copy link

trypton commented Nov 21, 2017

Are you reporting a feature request or a bug?

Improvement

Provide detailed reproduction steps (if any)

  1. Load any page with CKEditor
  2. Open browser dev tools
  3. Make sure some loaded files (like tableselection.css) have no timestamp query param

Expected result

CKEDITOR.getUrl() is always used to load any editor source.

Actual result

Some plugins (like tableselection, widget, scayt) don't use CKEDITOR.getUrl(). In common case, it is inconsistency and it prevents cache reset. In our case - we override CKEDITOR.getUrl() behavior by window.CKEDITOR_GETURL() - it prevents loading of some resources at all.

@glen-84
Copy link
Contributor

glen-84 commented Mar 4, 2019

@mlewand Would you accept a PR to add CKEDITOR.getUrl to the tableselection plugin?

Images referenced within CSS are still an issue though – could a build step be added that appends the timestamp to all image URLs within CSS files? (Edit: I see that this is already done with the editor.css file.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

3 participants