Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload widget should allow disabling default notifications #1145

Closed
mlewand opened this issue Nov 9, 2017 · 0 comments · Fixed by #1147
Closed

Upload widget should allow disabling default notifications #1145

mlewand opened this issue Nov 9, 2017 · 0 comments · Fixed by #1147
Labels
changelog:api A changelog entry should be put in the API section of the changelog. plugin:uploadwidget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.8.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 9, 2017

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

Currently when extending upload widget it forces you to use our notifications for progress info, succes / fail msg.

This is good for a quick, default case - but one might want to customize notifications.

For instance in Easy Image we want to put just small custom progress bar in a picture itself.

Thus developer should be able to override default handling.
@mlewand mlewand added changelog:api A changelog entry should be put in the API section of the changelog. status:confirmed An issue confirmed by the development team. type:feature A feature request. plugin:uploadwidget The plugin which probably causes the issue. target:major Any docs related issue that should be merged into a major branch. labels Nov 9, 2017
@mlewand mlewand added this to the Backlog milestone Nov 9, 2017
@mlewand mlewand mentioned this issue Nov 9, 2017
Merged
2 tasks
@mlewand mlewand modified the milestones: Backlog, 4.8.0 Nov 9, 2017
@mlewand mlewand mentioned this issue Nov 13, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:api A changelog entry should be put in the API section of the changelog. plugin:uploadwidget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

Added skipNotifications option to upload widget definition ckeditor/ckeditor4
1 participant
@mlewand