Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 'tests/plugins/tableselection/integrations/clipboard/pasteflow' crashes when browser viewport focused #1047

Closed
f1ames opened this issue Oct 13, 2017 · 3 comments
Assignees
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:failingtest A failing test.

Comments

@f1ames
Copy link
Contributor

f1ames commented Oct 13, 2017

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

Extracted from #962.
Similar to #945.

Provide detailed reproduction steps (if any)

The test tests/plugins/tableselection/integrations/clipboard/pasteflow started to fail (or rather break bender run in the same manner as mentioned in #945), after changes introduced in #962. However it only fails when browser viewport is focused (focusing browser window or browser URL field makes test run smoothly).

Also when changing tests order, from:

'test paste flow (tabular content)': function( editor, bot ) {
	testPasteFlow( bot, 'tabular-paste', '2cells1row' );
},

'test paste flow (non-tabular content)': function( editor, bot ) {
	testPasteFlow( bot, 'nontabular-paste', 'paragraph' );
}

to

'test paste flow (non-tabular content)': function( editor, bot ) {
	testPasteFlow( bot, 'nontabular-paste', 'paragraph' );
},

'test paste flow (tabular content)': function( editor, bot ) {
	testPasteFlow( bot, 'tabular-paste', '2cells1row' );
}	

it works fine despite the browser focus.

Other details

@f1ames f1ames added browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Oct 13, 2017
@beatadelura beatadelura added type:failingtest A failing test. and removed type:bug A bug. labels Oct 17, 2017
@msamsel msamsel self-assigned this Oct 30, 2017
@mlewand
Copy link
Contributor

mlewand commented Nov 13, 2017

Interestingly I can no longer repro it with (t/468 branch):

Microsoft Edge 41.16299.15.0
Microsoft EdgeHTML 16.16299

@f1ames
Copy link
Contributor Author

f1ames commented Nov 13, 2017

Just wanted to mention that simplest workaround (changing test order) is already present on #1153 (73a07fc) and this issue was to analyze the problem in more depth.

I will check if for the former test, the issue is still present on Edge 16.16299. If so I suggest to use the already present workaround as @msamsel fix is quite similar. If test will be passing on new Edge version, I will revert those change from #1153.

@f1ames
Copy link
Contributor Author

f1ames commented Nov 13, 2017

Confirmed that this issue no longer occurs in Edge 41.16299. I reverted the workaround d9e2162 on t/468.

@f1ames f1ames closed this as completed Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:failingtest A failing test.
Projects
None yet
Development

No branches or pull requests

4 participants