Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caching to Clipboard API fallback implementation for Edge #1026

Closed
f1ames opened this issue Oct 10, 2017 · 1 comment
Closed

Add caching to Clipboard API fallback implementation for Edge #1026

f1ames opened this issue Oct 10, 2017 · 1 comment
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. changelog:skip A changelog entry should not be added for a given issue. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.8.0

Comments

@f1ames
Copy link
Contributor

f1ames commented Oct 10, 2017

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

Extracted from #962 (see this particular comment).
Related to #468.

While the fallback logic for Edge 16+ not supporting custom MIME types in native dataTransfer.setData was implemented in #962, we still missing caching there which is quite important for performance reasons. We should only access native clipboard when needed (and not on every read if nothing changes).
@f1ames f1ames added browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc). labels Oct 10, 2017
@f1ames f1ames mentioned this issue Oct 10, 2017
Merged
2 tasks
@f1ames
Copy link
Contributor Author

f1ames commented Dec 1, 2017

This was closed with its parent task #468 in #1153.

@f1ames f1ames closed this as completed Dec 1, 2017
@mlewand mlewand added this to the 4.8.0 milestone Dec 1, 2017
@mlewand mlewand added the changelog:skip A changelog entry should not be added for a given issue. label Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. changelog:skip A changelog entry should not be added for a given issue. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.8.0
Development

No branches or pull requests
2 participants
@f1ames @mlewand