Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separator in toolbar moves when buttons are hovered with keyboard #2546

Closed
msamsel opened this issue Oct 31, 2018 · 2 comments
Closed

Separator in toolbar moves when buttons are hovered with keyboard #2546

msamsel opened this issue Oct 31, 2018 · 2 comments
Assignees
@engineering-this
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. regression This issue is a regression. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.2

Comments

@msamsel
Copy link
Contributor

msamsel commented Oct 31, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open full-all sample
  2. Press Alt+F10
  3. Start to move focus in toolbar with keyboard

oct-31-2018 09-40-39

Expected result

Separators are not moving

Actual result

Last separator change its position.

Other details

  • Browser: Chrome, IE10
  • OS: MacOS, Win7
  • CKEditor version: 4.11
  • Installed CKEditor plugins: …
@msamsel msamsel added type:bug A bug. status:confirmed An issue confirmed by the development team. labels Oct 31, 2018
@mlewand mlewand added the regression This issue is a regression. label Oct 31, 2018
@mlewand mlewand added this to the 4.11.0 milestone Oct 31, 2018
@mlewand mlewand added target:minor Any docs related issue that can be merged into a master or major branch. changelog:skip A changelog entry should not be added for a given issue. labels Oct 31, 2018
@mlewand
Copy link
Contributor

mlewand commented Oct 31, 2018

As @jacekbogdanski notes it's not a recent regression, it was introduced in 4.6.0. I'm surprised we did not noticed it so far.

@mlewand mlewand modified the milestones: 4.11.0, 4.11.1 Oct 31, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. and removed changelog:skip A changelog entry should not be added for a given issue. labels Oct 31, 2018
@mlewand mlewand modified the milestones: 4.11.1, 4.11.2 Nov 7, 2018
@engineering-this engineering-this self-assigned this Nov 27, 2018
@engineering-this engineering-this mentioned this issue Nov 27, 2018
Merged
2 tasks
@Comandeer
Copy link
Member

Merged into 4.11.2.

@mlewand mlewand changed the title Separator in toolbar moves when buttons are hoverd with keyboard Separator in toolbar moves when buttons are hovered with keyboard Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engineering-this engineering-this

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. regression This issue is a regression. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.2
Development

No branches or pull requests
5 participants
@Comandeer @mlewand @msamsel @jacekbogdanski @engineering-this