Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image 2 Plugin: Aspect ratio locking didn't work when change image #1348

Closed
ComvationAG opened this issue Dec 14, 2017 · 1 comment
Closed
Labels
plugin:image2 The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@ComvationAG
Copy link

Are you reporting a feature request or a bug?

type: Bug, plugin: image2

Provide detailed reproduction steps (if any)

  1. Open https://sdk.ckeditor.com/samples/captionedimage.html
  2. Doubleclick on image with rocket
  3. Change src to this image link: https://ckeditor.com/assets/images/og/ogimage-ck4.png
  4. Ensure that ratio is locked by lock symbol
  5. Change width to 300px
  6. Click now on "ok" to close image plugin dialog

Expected result

The new image should now updated with the prevented aspect ratio (widht: 300px, height: 157).

Actual result

The image is streateched, because the aspect ratio was not locked correctly.
The problem is, that the plugin calculated behind the aspect ratio based on old image (instead of new image).

As workaround you must first save by clicking "ok" the changed image, and open then the image plugin dialog again. Then the size calculation with ratio locking works.

Other details

  • Browser: whatsmybrowser.org/b/WWUE9MD
  • OS: Win 10
  • CKEditor version: 4.8.0 (Standard) // latest from demo page
  • Installed CKEditor plugins: image2 plugin

Thanks for investigate!

@ComvationAG ComvationAG changed the title Image 2 Plugin: Aspect ratio rock didn't when change image Image 2 Plugin: Aspect ratio lock didn't when change image Dec 14, 2017
@ComvationAG ComvationAG changed the title Image 2 Plugin: Aspect ratio lock didn't when change image Image 2 Plugin: Aspect ratio locking didn't work when change image Dec 14, 2017
@msamsel msamsel added plugin:image2 The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Dec 14, 2017
@msamsel
Copy link
Contributor

msamsel commented Dec 14, 2017

From what I check problem is not a regression, the same behaviour was present in 4.7.3 and 4.6.2.

@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Feb 2, 2018
@mlewand mlewand added this to the Backlog milestone Feb 2, 2018
@mlewand mlewand modified the milestones: Backlog, 4.10.1 Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:image2 The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants