Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKAN 2.9 #73

Open
davidread opened this issue Nov 22, 2019 · 0 comments
Open

CKAN 2.9 #73

davidread opened this issue Nov 22, 2019 · 0 comments

Comments

@davidread
Copy link
Contributor

There are test failures like this on master (CKAN 2.9), due to revision_id being removed from CKAN recently:

  File "/home/travis/build/ckan/ckanext-showcase/ckan/ckan/model/types.py", line 81, in process_bind_param

    return text_type(json.dumps(value, ensure_ascii=False))

  File "/home/travis/virtualenv/python2.7.13/lib/python2.7/site-packages/simplejson/__init__.py", line 397, in dumps

    **kw).encode(obj)

  File "/home/travis/virtualenv/python2.7.13/lib/python2.7/site-packages/simplejson/encoder.py", line 291, in encode

    chunks = self.iterencode(o, _one_shot=True)

  File "/home/travis/virtualenv/python2.7.13/lib/python2.7/site-packages/simplejson/encoder.py", line 373, in iterencode

    return _iterencode(o, 0)

  File "/home/travis/virtualenv/python2.7.13/lib/python2.7/site-packages/simplejson/encoder.py", line 268, in default

    raise TypeError(repr(o) + " is not JSON serializable")

StatementError: (exceptions.TypeError) <ckan.lib.navl.dictization_functions.Missing object at 0x7f555d64e810> is not JSON serializable

[SQL: INSERT INTO activity (id, timestamp, user_id, object_id, revision_id, activity_type, data) VALUES (%(id)s, %(timestamp)s, %(user_id)s, %(object_id)s, %(revision_id)s, %(activity_type)s, %(data)s)]

[parameters: [{'user_id': u'3c59c164-fc32-4778-9eac-4541644e2e77', 'timestamp': datetime.datetime(2019, 11, 22, 13, 29, 13, 81419), 'object_id': '8006e299-c241-4708-9c71-dce960c31cc0', 'revision_id': None, 'data': {'actor': u'test.ckan.net', 'package': {'relationships_as_object': [], 'num_tags': 0, 'id': u'8006e299-c241-4708-9c71-dce960c31cc0', 'metadata_created ... (572 characters truncated) ... : literal(u'<p>Just another test dataset.</p>'), 'extras': [], 'revision_id': <ckan.lib.navl.dictization_functions.Missing object at 0x7f555d64e810>}}, 'id': u'e9bd18fc-3c20-4e1b-914f-78e6f5551f4f', 'activity_type': 'new package'}]]

So I think we need a condition on the CKAN version, as to whether it is added to the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant