Skip to content

Commit

Permalink
test: sort the tests alphabetically
Browse files Browse the repository at this point in the history
As it is, when the tests run, there is no indicator as to how long the
tests will run, how many more tests are pending.

PR-URL: libuv#1543
Reviewed-By: Ben Noordhuis <[email protected]>
  • Loading branch information
thefourtheye authored and bnoordhuis committed Sep 27, 2017
1 parent 8d3645a commit c1ca7f0
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions test/runner.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@
char executable_path[sizeof(executable_path)];


static int compare_task(const void* va, const void* vb) {
const task_entry_t* a = va;
const task_entry_t* b = vb;
return strcmp(a->task_name, b->task_name);
}


const char* fmt(double d) {
static char buf[1024];
static char* p;
Expand Down Expand Up @@ -67,6 +74,7 @@ const char* fmt(double d) {


int run_tests(int benchmark_output) {
int actual;
int total;
int passed;
int failed;
Expand All @@ -76,13 +84,16 @@ int run_tests(int benchmark_output) {
task_entry_t* task;

/* Count the number of tests. */
actual = 0;
total = 0;
for (task = TASKS; task->main; task++) {
for (task = TASKS; task->main; task++, actual++) {
if (!task->is_helper) {
total++;
}
}

qsort(TASKS, actual, sizeof(TASKS[0]), compare_task);

fprintf(stderr, "1..%d\n", total);
fflush(stderr);

Expand Down Expand Up @@ -352,12 +363,6 @@ int run_test_part(const char* test, const char* part) {
}


static int compare_task(const void* va, const void* vb) {
const task_entry_t* a = va;
const task_entry_t* b = vb;
return strcmp(a->task_name, b->task_name);
}


static int find_helpers(const task_entry_t* task,
const task_entry_t** helpers) {
Expand Down

0 comments on commit c1ca7f0

Please sign in to comment.