Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

Continuous Integration Fails on R Versions < 3.4 #83

Closed
medewitt opened this issue May 25, 2021 · 1 comment
Closed

Continuous Integration Fails on R Versions < 3.4 #83

medewitt opened this issue May 25, 2021 · 1 comment

Comments

@medewitt
Copy link
Contributor

medewitt commented May 25, 2021

This I learned, isFALSE was introduced in R3.4.2. Right now in your DESCRIPTION file, you have R > 3 as the only restriction on the version of R users are required to have. In order to ensure this works for earlier versions of R you would need to change the following isFALSE sections to !isTRUE or more robust(!is.null(x) && !isTRUE(x))

if(isFALSE(is_retweet)) {

if(isFALSE(is_retweet)) {

The CRAN checks missed this because they only check 1 version past, current version, and devel versions of R.

openjournals/joss-reviews#3272

@justinchuntingho
Copy link
Collaborator

Thanks a lot! This is now fixed with #85
We changed the isFALSE sections to !isTRUE in build_query() and retired build_user_query() as its funtionalies are now replaced by other functions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants