Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send progress output to stderr instead of stdout #480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dipu989
Copy link
Contributor

@dipu989 dipu989 commented Oct 16, 2024

Pull Request Description

Fix for Issue #388: Spinner Output Cleanup

This pull request addresses the issue described in GitHub issue #388, where the spinner output was generating unprintable characters.

Changes Made:

Initialized the spinner with a default stderr writer.
Redirected all spinner output to stderr, ensuring that it does not interfere with standard output.
This adjustment prevents any unprintable characters from appearing in the final output, enhancing the overall user experience when using the CLI.

Before Change -
WhatsApp Image 2024-10-16 at 8 15 05 AM

After Change -
Screenshot 2024-10-16 at 8 24 13 AM

Impact:
This change improves the clarity and usability of the Civo CLI by ensuring that output for this particular command (with -wait flag) is formatted correctly in every case.

@dipu989
Copy link
Contributor Author

dipu989 commented Oct 16, 2024

@uzaxirr @fernando-villalba
For now, I have only proposed a solution for the command mentioned in the ticket. If this approach looks good, I can raise similar changes for subsequent commands that support the -wait flag as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant