Add additional information to the error message #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
hlts2
commented
Nov 19, 2024
Comment on lines
-23
to
-24
| csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER: struct{}{}, | ||
| csi.VolumeCapability_AccessMode_SINGLE_NODE_READER_ONLY: struct{}{}, |
There was a problem hiding this comment.
Note
Since the struct specifications is not necessary, it has been removed 🙏
hlts2
commented
Nov 19, 2024
| @@ -105,10 +105,10 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest) | |||
| availableSize := int64(quota.DiskGigabytesLimit - quota.DiskGigabytesUsage) | |||
| if availableSize < desiredSize { | |||
| log.Error().Msg("Requested volume would exceed storage quota available") | |||
| return nil, status.Error(codes.OutOfRange, fmt.Sprintf("Requested volume would exceed volume space quota by %d GB", desiredSize-availableSize)) | |||
There was a problem hiding this comment.
Note
I changed it to pass the arguments directory to status.Errorf, which achieves the same result.
This makes the implementation simpler.
hlts2
requested review from
rytswd,
RealHarshThakur,
Praveen005 and
chadmcrowell
hlts2
changed the title
RealHarshThakur
approved these changes
Nov 19, 2024
rytswd
approved these changes
Nov 19, 2024
|
@RealHarshThakur @rytswd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add additional information, such as the volume id and current state ..etc, to error returned by the handler
WHY
To make it easier to identify the cause of issue by including more detailed information in the error messages, improving debugging efficiency.
FYI
💡 There are no logic changes to this PR.