Set driver version in the binary based on release version #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binary Signed-off-by: hlts2 <[email protected]>
|
@rytswd @DMajrekar @Praveen005 |
hlts2
commented
Nov 6, 2024
hlts2
commented
Nov 6, 2024
Praveen005
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
The release version has been modified to be mappable to the binary.
Additionally, a flag to output the version information has been added.
This allows the version information to be checked without making an RPC call.
WHY
The version information of binary is incorrect. (The value returned by the RPC will be
0.0.1.)FYI
This PR has been tested using the following methods.
This version will be returned by RPC
$ docker run --rm {IMAGE_ID} --version 7:08AM INF CSI driver version=v1.10.4