Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-polyfill replaces existing Promise implementation #5

Closed
adrian-gierakowski opened this issue Aug 29, 2017 · 2 comments
Closed
Assignees

Comments

@adrian-gierakowski
Copy link

adrian-gierakowski commented Aug 29, 2017

same as: feathersjs/feathers#510

it is very well described in the above issue so I will not repeat it here ( it would suffice to copy and paste replacing feathers with civic-sip-api )

for others needing a workaround util this is resolved, replace:

global.Promise = require("bluebird")

with

Object.defineProperty(global, "Promise", {
  value:require("bluebird"),
  writable:false
})
@slaphead
Copy link
Contributor

slaphead commented Aug 29, 2017

@adrian-gierakowski Thanks for giving the background here. Busy looking into it.

@slaphead slaphead self-assigned this Aug 29, 2017
@slaphead
Copy link
Contributor

Updated to use babel-runtime to stop polluting globals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants