Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: Enable 5 missing specific attributes in citrixadc_appfwprofile ressource #1135

Closed
nogiiihhmk opened this issue Apr 10, 2024 · 2 comments · Fixed by #1138
Closed
Assignees
Labels
enhancement In-Progress ..being worked upon

Comments

@nogiiihhmk
Copy link

nogiiihhmk commented Apr 10, 2024

Description

Hi Citrix,

we use attributes like

  • htmlerrorstatuscode
  • htmlerrorstatusmessage
  • bufferoverflowmaxtotalheaderlength
  • sqlinjectiongrammar
  • cmdinjectiontype

in classic wafprofile and as we are migrating classic waf config to use that in terraform as a attributes of citrixadc_appfwprofile. In CLI these setting are possible, but not in terraform as documented in https://registry.terraform.io/providers/citrix/citrixadc/latest/docs/resources/appfwprofile. Also Citrix CLI docs at https://developer-docs.netscaler.com/en-us/adc-command-reference-int/current-release/appfw/appfw-profile.html are showing these attributes.

Could you please enable usage of these attributes in citrixadc_appfwprofile terraform ressource?

Regards,
Nico

Affected Resource(s) and/or Data Source(s)

citrixadc_appfwprofile

Equivalent NetScaler CLI Command

htmlerrorStatusCode:
set appfw profile WAF_PROFILENAME -htmlerrorStatusCode 400

htmlerrorStatusMessage
set appfw profile WAF_PROFILENAME -htmlerrorStatusMessage "Forbidden"

bufferoverflowmaxtotalheaderlength
set appfw profile WAF_PROFILENAME -bufferoverflowmaxtotalheaderlength 1000

sqlinjectiongrammar
set appfw profile WAF_PROFILENAME -sqlinjectiongrammar "OFF"

cmdinjectiontype
set appfw profile WAF_PROFILENAME -cmdinjectiontype "CMDSplCharORKeyword"

Potential Terraform Configuration

resource "citrixadc_appfwprofile" "demo_appfw" {
  htmlerrorStatusCode = 400
  htmlerrorStatusMessage = "Forbidden"
  bufferoverflowmaxtotalheaderlength = 1
  sqlinjectiongrammar = "ON"
  cmdinjectiontype = "CMDSplCharANDKeyword"  
  #...
  # and all the other mandatory attributes
}

References

https://developer-docs.netscaler.com/en-us/adc-command-reference-int/current-release/appfw/appfw-profile.html

@nogiiihhmk nogiiihhmk changed the title [FEATURE REQUEST]: Enable setting htmlerrorstatuscode and htmlerrorstatusmessage in citrixadc_appfwprofile [FEATURE REQUEST]: Enable 5 missing specific attributes in citrixadc_appfwprofile ressource Apr 10, 2024
@rohit-myali rohit-myali added the In-Progress ..being worked upon label Apr 15, 2024
@rohit-myali
Copy link
Contributor

Hello @nogiiihhmk
Thanks for raising this feature request.

We have worked on this and and it is now available in the terraform registry. Please download the latest terraform-provider-citrixadc version v1.38.0.

Link to documentation HERE

Thank you

@nogiiihhmk
Copy link
Author

Thank you.

@rohit-myali rohit-myali self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement In-Progress ..being worked upon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants