Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add attribute support to gslbservicegroup resource #1127

Closed
gusmb opened this issue Mar 20, 2024 · 3 comments · Fixed by #1146
Closed

[FEATURE REQUEST] Add attribute support to gslbservicegroup resource #1127

gusmb opened this issue Mar 20, 2024 · 3 comments · Fixed by #1146
Assignees
Labels
In-Progress ..being worked upon

Comments

@gusmb
Copy link

gusmb commented Mar 20, 2024

Contact us

For any immediate issues or help , reach out to us at [email protected] !

Feature Request

I want to configure gslbservicegroup (https://registry.terraform.io/providers/citrix/citrixadc/latest/docs/resources/gslbservicegroup) in a similar way as servicegroup for SLB, managing the bindings implicitly and not explicitly by defining them separately. The following requirements need to be met:

  • gslbservicegroup can be bound to multiple members
  • gslbservicegroup can be bound to a gslbvserver
  • gslbservicegroup can be bound to multiple monitors

Describe the solution you'd like
Would like to be able to define the gslbservicegroup with all implicit bindings, like this:

resource "citrixadc_gslbservicegroup" "tf_gslbservicegroup" {
  servicegroupname = "test_gslbvservicegroup"
  servicetype      = "HTTP"
  cip              = "DISABLED"
  sitename         = citrixadc_gslbsite.site_local.sitename
  gslbservicegroupmembers = ["172.20.0.9:80:10", "172.20.0.10:80:10", "172.20.0.11:8080:20"]
  gslbvservers = [ citrixadc_lbvserver.tf_lbvserver1.name, citrixadc_lbvserver.tf_lbvserver2.name ]
  lbmonitorbinding = [
    {
      monitor_name = "mymonitor"
      monstate = "ENABLED"
      weight = 1
    }
  ]
}

Since servicegroup member can be in this case server or SLB vips, the setting might need to be flexible to specify server by name or just VIP address (IP based binding)

Describe alternatives you've considered
Doing explicit bindings using separate resource objects. I would like to avoid this if possible

Additional context
Add any other context or screenshots about the feature request here.

@gusmb
Copy link
Author

gusmb commented Mar 20, 2024

Also, there is even no explicit way to bind gslbservicegroup with members at this point

@rohit-myali rohit-myali added the In-Progress ..being worked upon label Apr 19, 2024
@rohit-myali
Copy link
Contributor

rohit-myali commented Apr 19, 2024

Hey @gusmb

we are not planning on combining binding with individual resources, as it creates complexity in implementing and debugging the resource.

So, I have implemented new resource to bind gslbservicegroup to gslbservicegroupmembers, which will be released today to the terraform registry. I will update you post release.

Thanks

@rohit-myali
Copy link
Contributor

Hello @gusmb
Thanks for raising this feature request.
We have released this and it is now available in the terraform registry. Please download the latest terraform-provider-citrixadc version v1.38.0.

Link to documentation HERE

@rohit-myali rohit-myali self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-Progress ..being worked upon
Projects
None yet
2 participants