Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalise colour var names #1418

Open
davidsauntson opened this issue Aug 11, 2021 · 0 comments
Open

Rationalise colour var names #1418

davidsauntson opened this issue Aug 11, 2021 · 0 comments
Assignees
Labels
tech debt Technical tasks that would usually form a contribution

Comments

@davidsauntson
Copy link
Contributor

Currently the colour variable names are a bit all over the place and the design system colour palette includes product specific colours for advisernet. We need to:

  • use a consistent approach to naming colour language variables so they can be more easily understood and overridden by products (suggest smth along the lines of ${component}__{element}__{property}--{state})
    • eg $cads-header__link-hover-colour should be smth like $cads-header__link__color--hover
  • remove advisernet product colours from palette and add into product specific css
@davidsauntson davidsauntson added the tech debt Technical tasks that would usually form a contribution label Aug 11, 2021
@marianayovcheva marianayovcheva self-assigned this Feb 11, 2022
@marianayovcheva marianayovcheva linked a pull request Mar 24, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical tasks that would usually form a contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants