From 4fffe5b3ec8605d5c8702dde818726a4c5487bcc Mon Sep 17 00:00:00 2001
From: Andrey Prokopenko <aprokop@users.noreply.github.com>
Date: Thu, 24 Nov 2016 15:25:22 -0500
Subject: [PATCH] Adding pic_flag property to compilers (#2375)

Different compilers have different flags for PIC (position-independent
code). This patch provides a common ground to accessing it inside specs.

See discussions in #508 and #2373. This patch does not address the issue
of mixed compilers as mentioned in #508.
---
 lib/spack/spack/compilers/clang.py | 4 ++++
 lib/spack/spack/compilers/gcc.py   | 4 ++++
 lib/spack/spack/compilers/intel.py | 4 ++++
 lib/spack/spack/compilers/nag.py   | 4 ++++
 lib/spack/spack/compilers/pgi.py   | 4 ++++
 lib/spack/spack/compilers/xl.py    | 4 ++++
 6 files changed, 24 insertions(+)

diff --git a/lib/spack/spack/compilers/clang.py b/lib/spack/spack/compilers/clang.py
index da18adcecd21a3..b2095defe5945e 100644
--- a/lib/spack/spack/compilers/clang.py
+++ b/lib/spack/spack/compilers/clang.py
@@ -78,6 +78,10 @@ def cxx11_flag(self):
             else:
                 return "-std=c++11"
 
+    @property
+    def pic_flag(self):
+        return "-fPIC"
+
     @classmethod
     def default_version(cls, comp):
         """The '--version' option works for clang compilers.
diff --git a/lib/spack/spack/compilers/gcc.py b/lib/spack/spack/compilers/gcc.py
index 557b1c13a96ab5..80d24910c36cc4 100644
--- a/lib/spack/spack/compilers/gcc.py
+++ b/lib/spack/spack/compilers/gcc.py
@@ -74,6 +74,10 @@ def cxx14_flag(self):
         else:
             return "-std=c++14"
 
+    @property
+    def pic_flag(self):
+        return "-fPIC"
+
     @classmethod
     def fc_version(cls, fc):
         return get_compiler_version(
diff --git a/lib/spack/spack/compilers/intel.py b/lib/spack/spack/compilers/intel.py
index 14f4d2dc91d483..4ff7185c846a85 100644
--- a/lib/spack/spack/compilers/intel.py
+++ b/lib/spack/spack/compilers/intel.py
@@ -65,6 +65,10 @@ def cxx11_flag(self):
         else:
             return "-std=c++11"
 
+    @property
+    def pic_flag(self):
+        return "-fPIC"
+
     @classmethod
     def default_version(cls, comp):
         """The '--version' option seems to be the most consistent one
diff --git a/lib/spack/spack/compilers/nag.py b/lib/spack/spack/compilers/nag.py
index 5ba235adbbc3da..c1da95a6c32948 100644
--- a/lib/spack/spack/compilers/nag.py
+++ b/lib/spack/spack/compilers/nag.py
@@ -56,6 +56,10 @@ def cxx11_flag(self):
         # However, it can be mixed with a compiler that does support it
         return "-std=c++11"
 
+    @property
+    def pic_flag(self):
+        return "-PIC"
+
     # Unlike other compilers, the NAG compiler passes options to GCC, which
     # then passes them to the linker. Therefore, we need to doubly wrap the
     # options with '-Wl,-Wl,,'
diff --git a/lib/spack/spack/compilers/pgi.py b/lib/spack/spack/compilers/pgi.py
index 37ffe44028ae2e..146c153041811f 100644
--- a/lib/spack/spack/compilers/pgi.py
+++ b/lib/spack/spack/compilers/pgi.py
@@ -55,6 +55,10 @@ def openmp_flag(self):
     def cxx11_flag(self):
         return "-std=c++11"
 
+    @property
+    def pic_flag(self):
+        return "-fpic"
+
     @classmethod
     def default_version(cls, comp):
         """The '-V' option works for all the PGI compilers.
diff --git a/lib/spack/spack/compilers/xl.py b/lib/spack/spack/compilers/xl.py
index 5c83209781bf28..f4b7c4237dbfaa 100644
--- a/lib/spack/spack/compilers/xl.py
+++ b/lib/spack/spack/compilers/xl.py
@@ -58,6 +58,10 @@ def cxx11_flag(self):
         else:
             return "-qlanglvl=extended0x"
 
+    @property
+    def pic_flag(self):
+        return "-qpic"
+
     @classmethod
     def default_version(cls, comp):
         """The '-qversion' is the standard option fo XL compilers.