-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip protocol #405
Strip protocol #405
Conversation
Implementation note: Technically you can come across FTP links, however rare these days (and browsers have stopped supporting them for whatever reason). It's possible we'll have academia using IPFS or something soon enough too. The appropriate way to deal with this is to have a whitelist that it applies to (not configurable per style), not to do it blindly. FTP and IPFS links should not have the protocol stripped because they're not implied by overwhelming common usage like http/https are. Http/https should be the only ones. I'd also strip |
Yep, this would only apply to http/https and I think only to the URL field |
That's not ready for review, right? |
It's ready for review. It's just adding the one style attribute we discussed in the linked issue |
But this commit only adds this to the list of possible options on
So, I'd think something similar would be needed:
Should the default value be true or false? |
FWIW, relax ng doesn't truly support default values. We include them for documentation purposes, where I think it does help add to the clarity. |
@denismaier ah, right. Can you add that? Default to false |
I don't know how to commit directly to your PR, but I'll add this as a suggestion. |
Description
Adds a style attribute specifying that
https://
andhttp://
should be stripped from rendered URLs.Fixes # (issue)
Type of change
Checklist