Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Integration Test for Maker's RPC #205

Open
Shourya742 opened this issue Jul 7, 2024 · 1 comment · May be fixed by #311
Open

Implement Integration Test for Maker's RPC #205

Shourya742 opened this issue Jul 7, 2024 · 1 comment · May be fixed by #311
Labels
tests Testing related improvements
Milestone
v0.1.0

Comments

@Shourya742
Copy link

Task

  • Write a test scenario where a maker is spawned with a backend bitcoind.
  • Query the RPC port using an RPC call.

Details

  • This test should be similar to our existing integration tests.
  • Use the test framework to spawn makers.
  • Make queries to the maker's RPC port and verify the correctness of the responses.

Expected Outcome

  • The test should successfully query the maker's RPC port and return correct responses, validating the functionality of the maker's RPC.
@mojoX911
Copy link

Further info:

This issue is for creating the first template of this type of test. It's okay if all the maker-cli commands are not covered in the solving PR. Once the template is ready we can add tests for further commands in subsequent PRs.

@mojoX911 mojoX911 added tests Testing related improvements app labels Jul 18, 2024
@mojoX911 mojoX911 moved this to todo in core lib Jul 18, 2024
@mojoX911 mojoX911 added this to the v0.1.0 milestone Jul 20, 2024
@mojoX911 mojoX911 linked a pull request Nov 7, 2024 that will close this issue
Makercli testing #275
Closed
@mojoX911 mojoX911 moved this from todo to WIP in core lib Nov 12, 2024
@mojoX911 mojoX911 removed app labels Nov 12, 2024
@mojoX911 mojoX911 linked a pull request Nov 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Testing related improvements
Projects
core lib
Status: WIP
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Maker Cli testing mojoX911/coinswap
Makercli testing 007harshmahajan/coinswap
2 participants
@mojoX911 @Shourya742