Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require C++14 when tests are enabled #3807

Open
barracuda156 opened this issue Nov 17, 2024 · 3 comments
Open

Require C++14 when tests are enabled #3807

barracuda156 opened this issue Nov 17, 2024 · 3 comments

Comments

@barracuda156
Copy link

gtest requires C++14:

  FAILED: test/api/test_api.p/BaseDecoderTest.cpp.o 
  /usr/bin/clang++ -Itest/api/test_api.p -Itest/api -I../openh264-2.5.0/test/api -Icodec/api/wels -I../openh264-2.5.0/codec/api/wels -I../openh264-2.5.0/codec/common/inc -Itest -I../openh264-2.5.0/test -I/opt/local/include -fdiagnostics-color=always -Wall -Winvalid-pch -O2 -g -Wno-non-virtual-dtor -Werror -Wunused-but-set-variable -Wno-strict-aliasing -DHAVE_AVX2 -pipe -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -arch x86_64 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -Wno-dangling-else -MD -MQ test/api/test_api.p/BaseDecoderTest.cpp.o -MF test/api/test_api.p/BaseDecoderTest.cpp.o.d -o test/api/test_api.p/BaseDecoderTest.cpp.o -c ../openh264-2.5.0/test/api/BaseDecoderTest.cpp
  In file included from ../openh264-2.5.0/test/api/BaseDecoderTest.cpp:2:
  In file included from /opt/local/include/gtest/gtest.h:63:
  In file included from /opt/local/include/gtest/gtest-assertion-result.h:46:
  In file included from /opt/local/include/gtest/gtest-message.h:57:
  /opt/local/include/gtest/internal/gtest-port.h:279:2: error: C++ versions less than C++14 are not supported.
  #error C++ versions less than C++14 are not supported.
   ^
  /opt/local/include/gtest/internal/gtest-port.h:955:12: error: no member named 'make_tuple' in namespace 'std'
  using std::make_tuple;
        ~~~~~^
  /opt/local/include/gtest/internal/gtest-port.h:956:12: error: no member named 'tuple' in namespace 'std'
  using std::tuple;
        ~~~~~^
  /opt/local/include/gtest/internal/gtest-port.h:966:27: error: deleted function definitions are a C++11 extension [-Werror,-Wc++11-extensions]
    Secret(const Secret&) = delete;
                            ^
  /opt/local/include/gtest/internal/gtest-
@aeiouaeiouaeiouaeiouaeiouaeiou

I would say C++17, since it actually requires [maybe_unused].

@barracuda156
Copy link
Author

@aeiouaeiouaeiouaeiouaeiouaeiou As of now, it works with -std=c++14, AFAICT.

@aeiouaeiouaeiouaeiouaeiouaeiou

#3809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants