Check for HSTS on all redirects on same endpoint #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
requested changes
May 21, 2019
…ttps://github.com/cisagov/pshtt into issue/Factor_in_redirects_when_calculating_HSTS_#89
|
@jsf9k, I added some code to record the HSTS URL and redirect chain so you can always see which URL the HSTS header that is being checking is coming from. In the output there are now lines that say ": Found HSTS in redirected response from ". In my tests, the code ensures that the redirected URL is on the same endpoint and I can see that in these lines in the output. |
|
This PR resolves #196. |
jsf9k
approved these changes
Aug 9, 2019
jsf9k
added a commit
to cisagov/lambda_functions
that referenced
this pull request
Aug 9, 2019
See cisagov/pshtt#193 for details.
jsf9k
added a commit
to cisagov/scanner
that referenced
this pull request
Aug 9, 2019
See cisagov/pshtt#193 for details.
jsf9k
added a commit
to 18F/domain-scan
that referenced
this pull request
Aug 9, 2019
See cisagov/pshtt#193 for more details.
jsf9k
added a commit
to cisagov/orchestrator
that referenced
this pull request
Aug 9, 2019
See cisagov/pshtt#193 for more details.
jsf9k
requested changes
Aug 9, 2019
jsf9k
approved these changes
Aug 20, 2019
|
Closed due to a lack of attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve Issue #89 Factor in redirects when calculating HSTS by looking at all redirects to the same endpoint for an HSTS header, rather than only the first response and no redirects.