Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No logic in install for certain hard drive sizes #104

Closed
aarz-snl opened this issue Dec 13, 2023 · 1 comment
Closed

[BUG] No logic in install for certain hard drive sizes #104

aarz-snl opened this issue Dec 13, 2023 · 1 comment
Assignees
Labels
bug This issue or pull request addresses broken functionality

Comments

@aarz-snl
Copy link
Collaborator

In the function data_retention you have this logic:

if [ "$DISK_80" -lt 30 ]; then
echo -e "\e[31m[!]\e[0m LME Requires 128GB of space usable for log retention - exiting"
exit 1
elif [ "$DISK_80" -ge 90 ] && [ "$DISK_80" -le 179 ]; then
RETENTION="30"
elif [ "$DISK_80" -ge 180 ] && [ "$DISK_80" -le 359 ]; then
RETENTION="90"
elif [ "$DISK_80" -ge 360 ] && [ "$DISK_80" -le 539 ]; then
RETENTION="180"
elif [ "$DISK_80" -ge 540 ] && [ "$DISK_80" -le 719 ]; then
RETENTION="270"
elif [ "$DISK_80" -ge 720 ]; then
RETENTION="365"
else
echo -e "\e[31m[!]\e[0m Unable to determine retention policy - exiting"
exit 1
fi

In it's current form there is no logic that accounts for 30-89. So, anyone who tries to install LME falling within that range will be met with "Unable to determine retention policy - exiting"

Additionally, the echo statement that states "LME Requires 128 GB of space" doesn't align with the first rule which states if less than 30 GB.

@aarz-snl aarz-snl added the bug This issue or pull request addresses broken functionality label Dec 13, 2023
@aarz-snl aarz-snl self-assigned this Jan 2, 2024
@llwaterhouse
Copy link
Contributor

Fixed with #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants