Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The [skip ci] option shouldn't count as CIRRUS_LAST_GREEN_CHANGE #891

Closed
leshik opened this issue Jul 27, 2021 · 1 comment
Closed

The [skip ci] option shouldn't count as CIRRUS_LAST_GREEN_CHANGE #891

leshik opened this issue Jul 27, 2021 · 1 comment
Labels

Comments

@leshik
Copy link

leshik commented Jul 27, 2021

Description

Don't use git commit sha for the CIRRUS_LAST_GREEN_CHANGE env variable if [skip ci] option was used.

Context

Right now it's possible to work around the failed build by just updating e.g. README.md, and setting [skip ci] in the commit message. This breaks setups that use the CIRRUS_LAST_GREEN_CHANGE env to e.g. lint only changed files, or in case the suite is skipped completely if there are no changes to some specific files.

@leshik leshik added the feature label Jul 27, 2021
@fkorotkov
Copy link
Contributor

Skipped builds should be ignored now while calculating last green build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants