Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I couldn't detect any installed dependencies. #660

Closed
thevenomsnake opened this issue Jan 7, 2024 · 12 comments · Fixed by #682
Closed

I couldn't detect any installed dependencies. #660

thevenomsnake opened this issue Jan 7, 2024 · 12 comments · Fixed by #682

Comments

@thevenomsnake
Copy link

Describe the bug

Expected behavior
I have already installed zip and KindleGen, but it still prompts me to install dependencies and the conversion function cannot run.

Screenshots
20240107200534

Desktop (please complete the following information):

  • OS: [Windows 11]
@thevenomsnake
Copy link
Author

5.6.5 btw

@thevenomsnake
Copy link
Author

I just put "kindlegen.exe" on the same floder and fixed it.Now still showing "Install 7z(link)"

@axu2
Copy link
Collaborator

axu2 commented Jan 7, 2024

Why is the font different than usual? @thevenomsnake

What happens when you type in these addresses into File Explorer? This is where KCC is looking for kindlegen and 7z

%LOCALAPPDATA%\Amazon\Kindle Previewer 3\lib\fc\bin\
C:\Program Files\7-Zip

If it didn't install there where did it install?

Did you click the links in the kcc gui? https://github.com/ciromattia/kcc?tab=readme-ov-file#prerequisites

@thevenomsnake
Copy link
Author

I understand now where the problem was. I usually avoid installing software on the C drive, so there were no files in the two default locations you mentioned. I reinstalled the software to the default location, and now the problem is resolved.

@shihong5858
Copy link

I just found this issue and I think this should be fixed ...
I think kcc could try to locate the 7zip using system PATH, otherwise it's really confusing for people (this is not documented as well)

@axu2
Copy link
Collaborator

axu2 commented Mar 12, 2024

@shihong5858 what version of kcc are you using? And where did you put the kcc.exe? It should search for kcc automatically if you didn't change default install path. Try running kcc from desktop.

Did windows 11 change something? Are you using win11?

@shihong5858
Copy link

I'm running kcc 5.6.5 on Windows 10. kcc is located on E: drive while 7-zip is on D: drive. I tried uninstalled 7-zip and re-installed it on C: drive and the warning is gone and kcc function right.

I'm working on kcc-c2e now and was afraid the same issue could happen (I didn't verify it though since it's already on C: now) so I had to point it out. I think if we decide not to fix the mandatory path issue, atleast we should warn people in the README.

Thanks :)

@shihong5858
Copy link

Just to point it out: when I work with kcc-c2e, the stupid behavior on Powershell environment variable drove me crazy as well. I'm not sure if c2e would have the same concern (the [Environment]::GetEnvironmentVariables vs $env:Path)

@axu2
Copy link
Collaborator

axu2 commented Mar 12, 2024

@shihong5858 I think taking arbitrary drive letters would be a good feature. Is the only difference in the url C vs D?

When you first installed 7z it defaulted to D?

@thevenomsnake did you manually change it away from default C or did it default to another letter?

More info about c2e in

@shihong5858
Copy link

@axu2 right, I first installed 7z on D drive as lots ppl like me like to avoid installing software on default C drive.
And now I uninstalled the D one and re-installed 7z on C, and kcc works fine now.

My suggestion would be reading the 7z from the environment (usually through PATH), which is how most Windows users config their machine when they face the missing dependency errors.

@axu2
Copy link
Collaborator

axu2 commented Mar 13, 2024

I'll add the d and e drive as a search location for 7z. We do search path but 7z isn't added to path on install. You can tell because typing 7z into cmd doesn't work.

@shihong5858
Copy link

shihong5858 commented Mar 13, 2024

We do search path

I think in my case it wasn't searching the path, at least I saw the warning on UI and c2e error in Powershell when I have 7z added into PATH manually. I even tried 7z.exe in cmd and it's working (so I can confirm it was added into PATH)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants