Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases after 5.6.2 doesn't work on Windows 11 23H2 (22631.2792) #637

Closed
Trild opened this issue Dec 7, 2023 · 14 comments · Fixed by #639
Closed

Releases after 5.6.2 doesn't work on Windows 11 23H2 (22631.2792) #637

Trild opened this issue Dec 7, 2023 · 14 comments · Fixed by #639
Labels
Windows Windows OS
Milestone

Comments

@Trild
Copy link

Trild commented Dec 7, 2023

Describe the bug
Traceback (most recent call last):
File "kcc.py", line 74, in
File "kindlecomicconverter\startup.py", line 39, in start
File "kindlecomicconverter\KCC_gui.py", line 1050, in init
File "kindlecomicconverter\KCC_gui.py", line 859, in detectKindleGen
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xad in position 8: invalid start byte

To Reproduce
Steps to reproduce the behavior:

  1. Just open a kcc

Screenshots
изображение_2023-12-07_134617959
изображение_2023-12-07_134705558

Desktop (please complete the following information):

  • OS: Windows 11
@axu2
Copy link
Collaborator

axu2 commented Dec 7, 2023

@Trild
Can you try this build?

  • removed

The code is from

@Trild
Copy link
Author

Trild commented Dec 7, 2023

@axu2 it works but i get a new one
first one: when i click "Editor"
изображение_2023-12-07_195146039
second one: when i try to convert
изображение_2023-12-07_195210254

@Trild
Copy link
Author

Trild commented Dec 7, 2023

what interesting a month ago kcc works perfect. but if i delete windows updates it doesnt work

@axu2
Copy link
Collaborator

axu2 commented Dec 7, 2023

Why did you delete Windows Updates? @Trild

@Trild
Copy link
Author

Trild commented Dec 7, 2023

@axu2 just to check if they broke kcc

@axu2
Copy link
Collaborator

axu2 commented Dec 7, 2023

OK, I'll try just removing the KindleGen location ui check entirely.

https://github.com/axu2/kcc/actions/runs/7131952387

@Trild
Copy link
Author

Trild commented Dec 7, 2023

@axu2 it works good without any bugs or errors
thx

@axu2 axu2 added this to the 5.6.5 milestone Dec 7, 2023
@axu2 axu2 added the Windows Windows OS label Dec 7, 2023
@axu2
Copy link
Collaborator

axu2 commented Dec 8, 2023

@Trild
Can you please test this build as well, I believe I've done the proper fix now:
removed

@Trild
Copy link
Author

Trild commented Dec 9, 2023

@axu2 It starts, but the Editor does not work
image
And the convertation doesn't work
image

@axu2
Copy link
Collaborator

axu2 commented Dec 9, 2023

@Trild OK, maybe it was a bad idea to encode the output of 7z with utf-8. I'll just leave it in binary like it was originally in 5.6.2. Please try this:
https://github.com/axu2/kcc/actions/runs/7154194942

@Trild
Copy link
Author

Trild commented Dec 9, 2023

@axu2 now everything works without errors

@axu2
Copy link
Collaborator

axu2 commented Dec 10, 2023

@Trild Where did you get 7z? I just tried with 7z 23.01 from the website but couldn't reproduce the issue on Win10.

@axu2 axu2 closed this as completed in #639 Dec 10, 2023
@Trild
Copy link
Author

Trild commented Dec 10, 2023

@axu2 from the website (https: //www.7-zip .org/a/7z2301 -x64.exe)

@axu2
Copy link
Collaborator

axu2 commented Dec 10, 2023

Alright, so then there must be non utf8 characters inside the cbz, whether it's the file or folder names.

Thanks for the help debugging!

Lesson learned be very VERY careful with user input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants