Optimization Bug?

[venturaville]

In theory the caching should protect updates from happening constantly (needlessly). Without some mechanism to tie some sort of clear cache mechanism to an update having happened on this chef run the protection does not happen in practice. In fact without a clear cache every chef run results in an attempted update if there is any difference between circonus and the local copy. This is VERY slow to be doing every chef run.

Suggested solution: Trigger a cache clear at the end of the run if we perceive a difference that needed to be updated for.

[venturaville]

Note: It might be necessary to set a min and max cache time to protect against thundering herd on the API if a cookbook update goes out.

[venturaville]

(::File.ctime(cachepath) - Time.now).abs) > max_cache_time

One method of figuring that out...