Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Enabled proper GPU flag in pyproject.toml once Poetry is ready #14

Open
stroblme opened this issue Dec 5, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@stroblme
Copy link
Member

stroblme commented Dec 5, 2023

Describe the bug
The PR #9 actually does not fully solve the issue with Poetry and PyTorch. Original idea was to have a keyword "gpu" that can be provided as extra parameter to allow switching between CPU and GPU installation.
However, thttps://github.com/python-poetry/poetry/issues/7748 is an issue with the current version of poetry here which prevents this approach from working.
As I expect this to be fixed in the near future, I just disabled the line with the GPU source to simply un-comment it when Poetry fixes aforementioned issue.
Tmbk, toggling GPU/CPU install using the extra marker is the cleanest approach as long as no detection for GPU availability is available.

To Reproduce
Install the project

@stroblme stroblme added the bug Something isn't working label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant