From 88d1825c734e83c092b60380ecfd284c43e7b3fe Mon Sep 17 00:00:00 2001 From: Richard Howell Date: Fri, 18 Nov 2022 08:23:55 -0800 Subject: [PATCH] remove -weak_framework (#89233) Summary: X-link: https://github.com/pytorch/pytorch/pull/89233 The `-weak_framework` flag is no longer necessary, Buck will weakly link frameworks depending on the `target_sdk_version` of the binary being linked. Reviewed By: ebgraham, malfet Differential Revision: D41348639 fbshipit-source-id: 47992282ba030294b2304c550d49df13e24e9c79 --- BUCK | 7 +------ React/CoreModules/BUCK | 8 ++------ 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/BUCK b/BUCK index e998e2d09e5a88..f900a2be0e0e42 100644 --- a/BUCK +++ b/BUCK @@ -406,12 +406,6 @@ rn_apple_xplat_cxx_library( "-Wno-global-constructors", ], contacts = ["oncall+react_native@xmail.facebook.com"], - exported_linker_flags = [ - "-weak_framework", - "UserNotifications", - "-weak_framework", - "WebKit", - ], exported_preprocessor_flags = rn_extra_build_flags(), fbobjc_enable_exceptions = True, frameworks = [ @@ -426,6 +420,7 @@ rn_apple_xplat_cxx_library( "$SDKROOT/System/Library/Frameworks/SystemConfiguration.framework", "$SDKROOT/System/Library/Frameworks/UIKit.framework", "$SDKROOT/System/Library/Frameworks/UserNotifications.framework", + "$SDKROOT/System/Library/Frameworks/WebKit.framework", ], labels = [ "depslint_never_add", diff --git a/React/CoreModules/BUCK b/React/CoreModules/BUCK index 9820c22ed4b943..dec99e70172ec9 100644 --- a/React/CoreModules/BUCK +++ b/React/CoreModules/BUCK @@ -22,17 +22,13 @@ rn_apple_library( ], contacts = ["oncall+react_native@xmail.facebook.com"], enable_exceptions = True, - exported_linker_flags = [ - "-weak_framework", - "UserNotifications", - "-weak_framework", - "WebKit", - ], exported_preprocessor_flags = rn_extra_build_flags(), extension_api_only = True, frameworks = [ "Foundation", "UIKit", + "UserNotifications", + "WebKit", ], header_path_prefix = "React", labels = [