From 764d61e447535825edd612dfa8927b66fddd1d3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Charles=20Assun=C3=A7=C3=A3o?= Date: Thu, 10 Sep 2020 15:45:34 +0200 Subject: [PATCH] hotfix(Breadcrumb): content with children and example name (#14956) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes This PR renames the `BreadcrumbExample` to `BreadcrumbExampleBasic` to avoid the warning that is missing some example and fixes the console warning about `children` and `content` conflicting on `BreadcrumbDivider` #### Focus areas to test (optional) --- .../Types/{BreadcrumbExample.tsx => BreadcrumbExampleBasic.tsx} | 0 .../docs/src/examples/components/Breadcrumb/Types/index.tsx | 2 +- .../src/components/Breadcrumb/BreadcrumbDivider.tsx | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename packages/fluentui/docs/src/examples/components/Breadcrumb/Types/{BreadcrumbExample.tsx => BreadcrumbExampleBasic.tsx} (100%) diff --git a/packages/fluentui/docs/src/examples/components/Breadcrumb/Types/BreadcrumbExample.tsx b/packages/fluentui/docs/src/examples/components/Breadcrumb/Types/BreadcrumbExampleBasic.tsx similarity index 100% rename from packages/fluentui/docs/src/examples/components/Breadcrumb/Types/BreadcrumbExample.tsx rename to packages/fluentui/docs/src/examples/components/Breadcrumb/Types/BreadcrumbExampleBasic.tsx diff --git a/packages/fluentui/docs/src/examples/components/Breadcrumb/Types/index.tsx b/packages/fluentui/docs/src/examples/components/Breadcrumb/Types/index.tsx index 069c56d0c2ec6..a6da749cd9ab4 100644 --- a/packages/fluentui/docs/src/examples/components/Breadcrumb/Types/index.tsx +++ b/packages/fluentui/docs/src/examples/components/Breadcrumb/Types/index.tsx @@ -7,7 +7,7 @@ const Types = () => ( ); diff --git a/packages/fluentui/react-northstar/src/components/Breadcrumb/BreadcrumbDivider.tsx b/packages/fluentui/react-northstar/src/components/Breadcrumb/BreadcrumbDivider.tsx index 953feda93e3ad..d7b4521af18d5 100644 --- a/packages/fluentui/react-northstar/src/components/Breadcrumb/BreadcrumbDivider.tsx +++ b/packages/fluentui/react-northstar/src/components/Breadcrumb/BreadcrumbDivider.tsx @@ -81,7 +81,7 @@ export const BreadcrumbDivider = compose<'span', BreadcrumbDividerProps, Breadcr BreadcrumbDivider.defaultProps = { as: 'span', - content: '/', + children: '/', accessibility: breadcrumbDividerBehavior, };