Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "vendor: bump github.com/sirupsen/logrus from 1.9.0 to 1.9.1" #1042

Conversation

chancez
Copy link
Contributor

@chancez chancez commented May 17, 2023

Reverts #1039

See sirupsen/logrus#1383 for rationale. Additionally, the 1.9.1 release got yanked.

@chancez chancez requested a review from a team as a code owner May 17, 2023 19:02
@chancez chancez requested review from sayboras and removed request for a team May 17, 2023 19:02
@maintainer-s-little-helper
Copy link

Commit e3691de does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/contributing/#developer-s-certificate-of-origin

@chancez
Copy link
Contributor Author

chancez commented May 17, 2023

Alternatively #1038

@chancez chancez force-pushed the revert-1039-dependabot/go_modules/github.com/sirupsen/logrus-1.9.1 branch from e3691de to 1519922 Compare May 17, 2023 19:03
@rolinh
Copy link
Member

rolinh commented May 17, 2023

I merged the alternative, thanks!

@rolinh rolinh closed this May 17, 2023
@glibsm glibsm deleted the revert-1039-dependabot/go_modules/github.com/sirupsen/logrus-1.9.1 branch May 17, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label PR is blocked until the release note is set
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants