Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add continent function to location module #959

Closed
cieslarmichal opened this issue Oct 12, 2024 · 7 comments · Fixed by #985
Closed

add continent function to location module #959

cieslarmichal opened this issue Oct 12, 2024 · 7 comments · Fixed by #985
Assignees
@charan-003
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

No description provided.

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Oct 12, 2024
@smaliksmk
Copy link

Hello, I'd like to work on this issue.

@cieslarmichal
Copy link
Owner Author

Assigned

@charan-003
Copy link
Contributor

i want to work on this

@cieslarmichal
Copy link
Owner Author

Ok assigned

@charan-003
Copy link
Contributor

just wanted to confirm that i need to change files in location.cpp, location_data.h and test files right

@cieslarmichal
Copy link
Owner Author

Yes

@cieslarmichal
Copy link
Owner Author

cieslarmichal commented Nov 16, 2024 •
edited
Loading

Hello, please make changes in one PR instead of 4 :) it wont work that way

@charan-003 charan-003 mentioned this issue Nov 16, 2024
Closed
@cieslarmichal cieslarmichal linked a pull request Nov 18, 2024 that will close this issue
feat: added continents function #984 #985
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charan-003 charan-003

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added continents function #984 charan-003/faker-cxx
3 participants
@smaliksmk @cieslarmichal @charan-003