Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in line endings causes roundhouse to think the script has changed #162

Closed
lachok opened this issue Nov 14, 2014 · 3 comments
Closed

Comments

@lachok
Copy link

lachok commented Nov 14, 2014

One of our scripts has had it's line endings changed from Unix to Windows and this is causing roundhouse to not run it because the hash is different. I am going to fix the line endings, but want to ask a more general question.

Strictly speaking the content of the file has changed, but the meaning of it hasn't. I had a quick look at how hashing is done in roundhouse and didn't notice anything to handle this. Should roundhouse be aware of change of meaning as opposed to change of content?

@lahma
Copy link
Contributor

lahma commented Nov 14, 2014

This should already be handled with the latest release, support for detecting line ending changes was pulled in with pull request #104

@lachok
Copy link
Author

lachok commented Nov 14, 2014

Awesome, thanks! Not sure how I missed that.

@ferventcoder
Copy link
Member

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants