Enhancement: add web console for operations #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ansjsun <[email protected]>
Signed-off-by: ansjsun <[email protected]>
mervinkid
changed the title
Signed-off-by: ansjsun <[email protected]>
|
Greate job! How about commit the source code of html and javascript? After webpack,we can'nt understand and modify the web console. |
Signed-off-by: ansjsun <[email protected]>
Signed-off-by: ansjsun <[email protected]>
Signed-off-by: ansjsun <[email protected]>
awzhgw
reviewed
Jul 6, 2020
| "errors" | ||
| "fmt" | ||
| "github.com/chubaofs/chubaofs/proto" | ||
| client2 "github.com/chubaofs/chubaofs/sdk/graphql/client" |
There was a problem hiding this comment.
use graphqlClient replace client 2
There was a problem hiding this comment.
It is recommended to name it like gqlclient.
awzhgw
reviewed
Jul 6, 2020
|
|
||
| ctx := r.Context() | ||
|
|
||
| if r.RequestURI != "/login" { |
awzhgw
reviewed
Jul 6, 2020
cmd/cfg/console.json
Outdated
| "192.168.0.12:17010", | ||
| "192.168.0.13:17010" | ||
| ], | ||
| "monitor_addr": "http://cfsthanos-yf01.cfsmon.svc.zyx02.n.jd.local", |
There was a problem hiding this comment.
master_instance and monitor_addr and monitor_addr config variable Suggest to merge into one variable
Signed-off-by: ansjsun <[email protected]>
Signed-off-by: ansjsun <[email protected]>
|
@hooklee2000 The current submission is webpack. In the future, we may create a new respository to store page source code. |
Signed-off-by: ansjsun <[email protected]>
Signed-off-by: ansjsun <[email protected]>
Signed-off-by: ansjsun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
Special notes for your reviewer:
None.
Release note: