Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for '--version' and '--numeric-version' parser #57

Closed
chshersh opened this issue Aug 7, 2022 · 3 comments
Closed

Add test for '--version' and '--numeric-version' parser #57

chshersh opened this issue Aug 7, 2022 · 3 comments
Assignees
@CThuleHansen
Labels
cli-options CLI options, parsers good first issue Good for newcomers hacktoberfest https://hacktoberfest.com/ test
Milestone
v0.1.0.0: Improve...

Comments

@chshersh
Copy link
Owner

chshersh commented Aug 7, 2022

Similar to #56

Add unit tests for the --version and --numeric-version options parsing.
@chshersh chshersh added cli-options CLI options, parsers test good first issue Good for newcomers labels Aug 7, 2022
@chshersh chshersh mentioned this issue Sep 22, 2022
Merged
@chshersh chshersh moved this to Todo in Iris Project Sep 22, 2022
CThuleHansen added a commit to CThuleHansen/iris that referenced this issue Sep 22, 2022
@CThuleHansen
Fixes chshersh#56 and chshersh#57 along with PR 68 comments
fde50bb
@chshersh chshersh added the hacktoberfest https://hacktoberfest.com/ label Sep 27, 2022
CThuleHansen added a commit to CThuleHansen/iris that referenced this issue Oct 1, 2022
@CThuleHansen
Fixes chshersh#57
97098fa
@CThuleHansen CThuleHansen mentioned this issue Oct 1, 2022
Merged
@CThuleHansen
Copy link
Contributor

I have attempted this in #71

@chshersh chshersh moved this from Todo to In Progress in Iris Project Oct 3, 2022
chshersh added a commit that referenced this issue Oct 3, 2022
@CThuleHansen @chshersh
[#57] Add tests for the '--version' and '--numeric-version' flags (#71)
ef899ad 
Co-authored-by: Dmitrii Kovanikov <[email protected]>
@CThuleHansen
Copy link
Contributor

Pretty sure this can be closed according to #71

@chshersh chshersh added this to the v0.1.0.0: Improved UX milestone Oct 30, 2022
@chshersh
Copy link
Owner Author

@CThuleHansen Indeed! Thanks for the reminder 🙂

Repository owner moved this from In Progress to Done in Iris Project Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CThuleHansen CThuleHansen

Labels
cli-options CLI options, parsers good first issue Good for newcomers hacktoberfest https://hacktoberfest.com/ test
Projects
No open projects
Iris Project
Status: Done
Milestone
v0.1.0.0: Improved UX
Development

No branches or pull requests
2 participants
@CThuleHansen @chshersh