Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Support nullable arrays when using all_fields_required #185

Open
ikstewa opened this issue May 31, 2024 · 0 comments · May be fixed by #187
Open

Support nullable arrays when using all_fields_required #185

ikstewa opened this issue May 31, 2024 · 0 comments · May be fixed by #187

Comments

@ikstewa
Copy link

ikstewa commented May 31, 2024 •
edited
Loading

After 11e14e6 the all_fields_required flag respects the proto3 optional keyword.

According to the proto3 JSON Mapping a null json array is treated the same as an empty json array. I think it would make sense to follow the pattern with the proto3 optionl and also not mark repeated fields as required when mapping to json schema.
@ikstewa ikstewa linked a pull request May 31, 2024 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not mark repeated fields as optional ikstewa/protoc-gen-jsonschema
1 participant
@ikstewa