-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't let unstable-locales
imply the alloc
feature
#1307
Don't let unstable-locales
imply the alloc
feature
#1307
Conversation
97f7613
to
9c23d98
Compare
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1307 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 38 38
Lines 17068 17068
=======================================
Hits 15533 15533
Misses 1535 1535
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f40e155
to
b0adf08
Compare
All localized formatting methods now also depend on |
unstable-locales
depend on alloc
featureunstable-locales
imply the alloc
feature
I'm okay with this, but |
b0adf08
to
94d9e65
Compare
It did not bother me enough yet 😄. I have added a commit to clean that up. |
Nice, this also reduced the number of feature combinations the CI tests with 35%. |
I hope that at some point we add support for parsing different locales (should not be all that hard). And that we can make the new formatting API work without
alloc
(proven to be possible in #1163).In both cases it does not make much sense for the
unstable-locales
feature to imply thealloc
feature.This will break uses of chrono with
no-default-features
with theunstable-locales
feature, that happen to also depend onalloc
.I feel we are allowed to make this change because of the name unstable-locales.
Split out from #1163.