Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder/stateless: parser should be moved outside of the decoder state struct #86

Open
Gnurou opened this issue Jul 11, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Gnurou
Copy link
Collaborator

Gnurou commented Jul 11, 2024

We often perform mutable calls to the state while holding a non-mutable reference to the parser (e.g. to pass SPS information). This is currently not allowed because the parser is part of the state.

Every decoder has both a parser and a state though, so if we move the parser out of the state structure and make it another type parameter of StatelessCodec, we should be able to perform these calls avoid save a few redundant calls to fetch the same data.

@Gnurou Gnurou added the enhancement New feature or request label Jul 11, 2024
@Gnurou Gnurou self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant