Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular jest integration broken #60

Closed
tmeasday opened this issue Oct 26, 2018 · 2 comments
Closed

Angular jest integration broken #60

tmeasday opened this issue Oct 26, 2018 · 2 comments

Comments

@tmeasday
Copy link
Member

I think due to the new angular CLI version, when following the instructions on https://www.learnstorybook.com/angular/en/simple-component/ to install and use jest, I get babel errors -- maybe we need to setup jest slightly differently?

Jest encountered an unexpected token

    This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not plain JavaScript.

    By default, if Jest sees a Babel config, it will use that to transform your files, ignoring "node_modules".

    Here's what you can do:
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/en/configuration.html

    Details:

    /private/tmp/taskbox-angular-sb3/src/app/app.component.spec.ts:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import { TestBed, async } from '@angular/core/testing';
                                                                                             ^^^^^^

    SyntaxError: Unexpected token import

      at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:403:17)

NOTE: this is with @storybook/angular@rc -- the 4.0 version. SB3.4 doesn't work with the new angular CLI at all.

SECOND NOTE: to get storyshots working again there are some other small changes required, see this commit for hints: https://github.com/chromaui/learnstorybook.com/pull/59/files#diff-4501e37952bca452aa3f7d49ac721bee

@tmeasday
Copy link
Member Author

Any ideas @alterx ?

@jonniebigodes
Copy link
Collaborator

@domyen and @tmeasday i'm going to close this as this is already solved with #228.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants