Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraction of storybook stories appears broken since this morning. #858

Closed
FlorianSipgate opened this issue Nov 17, 2023 · 22 comments
Closed
Labels
bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation

Comments

@FlorianSipgate
Copy link

Bug report

Since this morning, uploading our stories using the chromatic CLI does not work and aborts with the following error:

The following error was encountered while running your Storybook:

Cannot destructure property 'provider' of 'undefined' as it is undefined.

The same commit worked yesterday.

See also: #703 (comment)

@FlorianSipgate FlorianSipgate added bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation labels Nov 17, 2023
@kim-fransson
Copy link

I can confirm that we have the same issue, tried upgrading chromatic-cli to 9.0.0 but no luck. Our storybook seems fine and I also build it locally with no obvious errors in the logs.

@dvasyliev
Copy link

dvasyliev commented Nov 17, 2023

I have the same issue and we didn't upgrade any storybook/chromatic version in the nearest week, everything was working yesterday.

Chromatic CLI v6.17.4
https://www.chromatic.com/docs/cli

  ✔ Authenticated with Chromatic
  ✔ Retrieved git information
  ✔ Collected Storybook metadata
  ✔ Initialized build
  ✔ Storybook built in 19 seconds
  ✔ Publish complete in 22 seconds
  ✖ Verifying your Storybook
    → Failed to publish build
    Test your stories

⚠ Using outdated package
You are using an outdated version of the Chromatic CLI (v6.17.4).
A new major version is available (v9.0.0).
Run yarn upgrade chromatic --latest to upgrade.

✖ Failed to extract stories from your Storybook
This is usually a problem with your published Storybook, not with Chromatic.

Build and open your Storybook locally and check the browser console for errors.
The following error was encountered while running your Storybook:

Cannot destructure property 'provider' of 'undefined' as it is undefined.

@cgbl-90
Copy link

cgbl-90 commented Nov 17, 2023

@dvasyliev @kim-fransson @FlorianSipgate, thanks for reporting! We're currently looking into this issue.

@mtzo09-dev
Copy link

Same issue here! The Storybook works perfectly, and the build runs without errors

@sherpadee
Copy link

Same issue here! The Storybook works perfectly, and the build runs without errors!

1 similar comment
@darkSalvation
Copy link

Same issue here! The Storybook works perfectly, and the build runs without errors!

@cgbl-90
Copy link

cgbl-90 commented Nov 17, 2023

Thanks for sharing @mtzo09-dev @sherpadee! We confirmed with other users that the Storybook is working fine. Looking at the Chromatic side of things now.

@expspace
Copy link

expspace commented Nov 17, 2023

Same issue for our team. It started to fail yesterday with the first build Nov. 16, 2023, 7:53 a.m.

Storybook works fine, even the link for the published version works, just the last step has the error "Failed to extract stories from your Storybook"

@marcusabu
Copy link

marcusabu commented Nov 17, 2023

Same issue here. All chromatic publish jobs are failing since this morning. Getting the error as described by @dvasyliev

@cgbl-90
Copy link

cgbl-90 commented Nov 17, 2023

We just deployed a fix to resolve this issue. Can you run a new build within 15 minutes?

cc: @afternoon2 @expspace

@marcusabu
Copy link

@cgbl-90 Ran a new build (using Chromatic CLI v9.1.0) but same error for me unfortunately

@JonathanKolnik
Copy link
Contributor

@marcusabu it should be released any minute, I'll follow up once it's out!

@mat-bishop
Copy link

looks good now!

@JonathanKolnik
Copy link
Contributor

Ok @marcusabu @expspace @afternoon2 the fix has been released, please try again

@afternoon2
Copy link

works 🎉 thank you very much 🤗

@JonathanKolnik
Copy link
Contributor

Awesome, sorry for the trouble here!

@expspace
Copy link

Working now thanks for the fix! 🎉

@shrink
Copy link

shrink commented Nov 17, 2023

For future incidents like this, it would be great if you could please publish acknowledgements to your status page and provide a link to the status page in the error message. Thank you :)

@tevanoff
Copy link
Contributor

@shrink thanks, you're absolutely right! We did add a retroactive update but will strive to add an update faster next time.

Thanks @JonathanKolnik for the quick fix! I'll close this one out now.

@kim-fransson
Copy link

Works here too, thanks for fixing ❤️

@goodwin64
Copy link

In our case upgrading the @storybook/jest from 0.1.0 to 0.2.3 helped.

@Rutulpatel7077
Copy link

Experiencing this now, worked yesterday but not now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation
Projects
None yet
Development

No branches or pull requests