-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to GEOS 3.10.5 and use GeoJSON Reader/Writer #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@chrispahm Thanks for response! |
Closed
Close this from #5 (comment) discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remembered that geos >= 3.10.0 supports GeoJSON Reader/Writer, so I updated geos version and use GeoJSON Reader/Writer.
Changes proposed in this pull request:
Buffer_simple.mjs
.Remove@turf/*
,d3-geo
andwkt
frompackage.json
- dependencies.Current performance test (on my M1 MacBook) is as follows and it is a bit faster than turf. 😄
I guess that keeping reader/writer instances during the loop may be better for further performance.(This means
buffer
method just accepts geomPtr and returns result bufferPtr for now, but it causes less usability, so something likeGeometry
object I/O may be better. (Not sure how Shapely manages it.))=> Delete (strike-through) these lines from #5 (comment).