Have assertString.js provide the invalid type passed to validator. #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
requested changes
Sep 24, 2018
src/lib/util/assertString.js
Outdated
| invalidType = `a ${invalidType}`; | ||
| } | ||
| } | ||
| let message = 'This library (validator.js) validates strings only, '; |
There was a problem hiding this comment.
Could the message just be this, to make it less verbose:
`Expected string but received ${invalidType}`
|
Thanks for your contribution @DCtheTall 🎉 Please check my comments above. |
|
@profnandaa ready for another look when you can. |
|
Sure, will be on it in the morning. Thx
On Tue, Sep 25, 2018 at 1:47 AM Dylan Cutler ***@***.***> wrote:
@profnandaa <https://github.com/ProfNandaa> ready for another look when
you can.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#895 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAP8kWWMXAsRr1GfBn1Vl03F3oukVrajks5ueWEIgaJpZM4Ws8QD>
.
--
Sent from a tiny device while on the move.
|
chriso
approved these changes
Sep 24, 2018
|
@DCtheTall -- thanks for getting your first contribution in! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #894 I thought it would be useful for
assertString.jsto provide which invalid type was used as an input.It checks explicitly for
null, otherwise it will usetypeof input. Iftypeof input === 'object'it will use the object's constructor's name (since'object'alone is rarely helpful), though if that seems like overkill I can take that out.